From: Shaohua Li Date: Thu, 27 Oct 2016 22:22:13 +0000 (-0700) Subject: raid5-cache: correct condition for empty metadata write X-Git-Tag: v4.9-rc4~3^2~2 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=9a8b27fac5bbb77337cc2e5d31d37c9936782d87;p=karo-tx-linux.git raid5-cache: correct condition for empty metadata write As long as we recover one metadata block, we should write the empty metadata write. The original code could make recovery corrupted if only one meta is valid. Reported-by: Zhengyuan Liu Signed-off-by: Shaohua Li --- diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c index 981f85515191..a227a9f3ee65 100644 --- a/drivers/md/raid5-cache.c +++ b/drivers/md/raid5-cache.c @@ -1087,7 +1087,7 @@ static int r5l_recovery_log(struct r5l_log *log) * 1's seq + 10 and let superblock points to meta2. The same recovery will * not think meta 3 is a valid meta, because its seq doesn't match */ - if (ctx.seq > log->last_cp_seq + 1) { + if (ctx.seq > log->last_cp_seq) { int ret; ret = r5l_log_write_empty_meta_block(log, ctx.pos, ctx.seq + 10);