From: Hillf Danton Date: Wed, 4 Apr 2012 00:07:57 +0000 (+1000) Subject: hugetlbfs: remove unregister_filesystem() when initializing module X-Git-Tag: next-20120404~1^2~109 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=9c3f259b27555332c4907b02820da0722bae6292;p=karo-tx-linux.git hugetlbfs: remove unregister_filesystem() when initializing module It was introduced by d1d5e05ffd ("hugetlbfs: return error code when initializing module") but as Al pointed out, is a bad idea. Quoted comments from Al. Note that unregister_filesystem() in module init is *always* wrong; it's not an issue here (it's done too early to care about and realistically the box is not going anywhere - it'll panic when attempt to exec /sbin/init fails, if not earlier), but it's a damn bad example. Consider a normal fs module. Somebody loads it and in parallel with that we get a mount attempt on that fs type. It comes between register and failure exits that causes unregister; at that point we are screwed since grabbing a reference to module as done by mount is enough to prevent exit, but not to prevent the failure of init. As the result, module will get freed when init fails, mounted fs of that type be damned. end of quote So remove it. Signed-off-by: Hillf Danton Cc: David Rientjes Cc: Al Viro Signed-off-by: Andrew Morton --- diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index ea251749d9d5..28cf06e4ec84 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -1031,7 +1031,6 @@ static int __init init_hugetlbfs_fs(void) } error = PTR_ERR(vfsmount); - unregister_filesystem(&hugetlbfs_fs_type); out: kmem_cache_destroy(hugetlbfs_inode_cachep);