From: H Hartley Sweeten Date: Wed, 16 Jul 2014 17:43:17 +0000 (-0700) Subject: staging: comedi: addi_apci_3xxx: checkpatch.pl cleanup (else after return) X-Git-Tag: v3.17-rc1~123^2~658 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=9ed221faae72ab1ad16e5f51d9f290e77af2c795;p=karo-tx-linux.git staging: comedi: addi_apci_3xxx: checkpatch.pl cleanup (else after return) Fix the checkpatch.pl warning in this file: WARNING: else is not generally useful after a break or return Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/addi_apci_3xxx.c b/drivers/staging/comedi/drivers/addi_apci_3xxx.c index 0532b6cc40e3..12096ee584ec 100644 --- a/drivers/staging/comedi/drivers/addi_apci_3xxx.c +++ b/drivers/staging/comedi/drivers/addi_apci_3xxx.c @@ -389,9 +389,8 @@ static int apci3xxx_ai_started(struct comedi_device *dev) if ((readl(devpriv->mmio + 8) & 0x80000) == 0x80000) return 1; - else - return 0; + return 0; } static int apci3xxx_ai_setup(struct comedi_device *dev, unsigned int chanspec) @@ -696,10 +695,9 @@ static int apci3xxx_dio_insn_config(struct comedi_device *dev, /* ignore all other instructions for ports 0 and 1 */ if (chan < 16) return -EINVAL; - else - /* changing any channel in port 2 */ - /* changes the entire port */ - mask = 0xff0000; + + /* changing any channel in port 2 changes the entire port */ + mask = 0xff0000; } ret = comedi_dio_insn_config(dev, s, insn, data, mask);