From: Daniel Borkmann Date: Thu, 16 Jun 2016 21:19:29 +0000 (+0200) Subject: net, cls: also reject deleting all filters when TCA_KIND present X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=9f6ed032cd951d2427995578c51af1b50c054efa;p=linux-beck.git net, cls: also reject deleting all filters when TCA_KIND present When we check for RTM_DELTFILTER, we should also reject the request for deleting all filters under a given parent when TCA_KIND attribute is present. If present, it's currently just ignored but there's also no point to let it pass in the first place either since this doesn't have any meaning with wild-card removal. Fixes: ea7f8277f907 ("net, cls: allow for deleting all filters for given parent") Signed-off-by: Daniel Borkmann Signed-off-by: David S. Miller --- diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index cca1ef5e5476..843a716a4303 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -169,7 +169,7 @@ replay: if (prio == 0) { switch (n->nlmsg_type) { case RTM_DELTFILTER: - if (protocol || t->tcm_handle) + if (protocol || t->tcm_handle || tca[TCA_KIND]) return -ENOENT; break; case RTM_NEWTFILTER: