From: Roger Quadros Date: Thu, 8 Dec 2016 08:45:31 +0000 (+0200) Subject: extcon: palmas: Check the parent instance to prevent the NULL X-Git-Tag: v4.11-rc1~118^2~100^2~18 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=9fe172b9be532acc23e35ba693700383ab775e66;p=karo-tx-linux.git extcon: palmas: Check the parent instance to prevent the NULL extcon-palmas must be child of palmas and expects parent's drvdata to be valid. Check for non NULL parent drvdata and fail if it is NULL. Not doing so will result in a NULL pointer dereference later in the probe() parent drvdata is NULL (e.g. misplaced extcon-palmas node in device tree). Signed-off-by: Roger Quadros Signed-off-by: Chanwoo Choi --- diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c index 634ba70782de..a128fd2eb187 100644 --- a/drivers/extcon/extcon-palmas.c +++ b/drivers/extcon/extcon-palmas.c @@ -190,6 +190,11 @@ static int palmas_usb_probe(struct platform_device *pdev) struct palmas_usb *palmas_usb; int status; + if (!palmas) { + dev_err(&pdev->dev, "failed to get valid parent\n"); + return -EINVAL; + } + palmas_usb = devm_kzalloc(&pdev->dev, sizeof(*palmas_usb), GFP_KERNEL); if (!palmas_usb) return -ENOMEM;