From: Takashi Iwai Date: Fri, 15 Apr 2016 13:28:52 +0000 (+0200) Subject: ALSA: lx646es: Fix possible uninitialized variable reference X-Git-Tag: v4.7-rc1~116^2~4^2~41 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=a19c921fca0a865b657d59b2c9a05aa0a2905126;p=karo-tx-linux.git ALSA: lx646es: Fix possible uninitialized variable reference lx_pipe_state() checks the return value from lx_message_send_atomic() and breaks the loop only when it's a negative value. However, lx_message_send_atomic() may return a positive error code (as the return code from the hardware), and then lx_pipe_state() tries to compare the uninitialized current_state variable. Fix this behavior by checking the positive non-zero error code as well. Reported-by: Dan Carpenter Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/lx6464es/lx_core.c b/sound/pci/lx6464es/lx_core.c index f3d62020ef66..a80684bdc30d 100644 --- a/sound/pci/lx6464es/lx_core.c +++ b/sound/pci/lx6464es/lx_core.c @@ -644,7 +644,7 @@ static int lx_pipe_wait_for_state(struct lx6464es *chip, u32 pipe, if (err < 0) return err; - if (current_state == state) + if (!err && current_state == state) return 0; mdelay(1);