From: Uwe Kleine-König Date: Fri, 12 Jun 2015 07:04:55 +0000 (+0200) Subject: media: i2c/adp1653: set enable gpio to output X-Git-Tag: v4.3-rc1~82^2~40^2~5 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=a33c380ef59353e550e852c82395306cf83cc7c0;p=karo-tx-linux.git media: i2c/adp1653: set enable gpio to output Without setting the direction of a gpio to output a call to gpiod_set_value doesn't have a defined outcome. Furthermore this is one caller less that stops us making the flags argument to gpiod_get*() mandatory. Acked-by: Sakari Ailus Acked-by: Pavel Machek Signed-off-by: Uwe Kleine-König --- diff --git a/drivers/media/i2c/adp1653.c b/drivers/media/i2c/adp1653.c index c70ababce954..5dd39775d6ca 100644 --- a/drivers/media/i2c/adp1653.c +++ b/drivers/media/i2c/adp1653.c @@ -465,7 +465,7 @@ static int adp1653_of_init(struct i2c_client *client, of_node_put(child); - pd->enable_gpio = devm_gpiod_get(&client->dev, "enable"); + pd->enable_gpio = devm_gpiod_get(&client->dev, "enable", GPIOD_OUT_LOW); if (!pd->enable_gpio) { dev_err(&client->dev, "Error getting GPIO\n"); return -EINVAL;