From: Jacek Anaszewski Date: Fri, 11 Jul 2014 15:19:43 +0000 (-0300) Subject: [media] s5p-jpeg: return error immediately after get_byte fails X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=a35f60031976d8b9930a2d32ebfdecd82d538066;p=linux-beck.git [media] s5p-jpeg: return error immediately after get_byte fails When parsing JPEG header s5p_jpeg_parse_hdr function should return immediately in case there was an error while reading a byte. Signed-off-by: Jacek Anaszewski Signed-off-by: Sylwester Nawrocki Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c index 126199e010c7..a3f8862e60f0 100644 --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c @@ -906,14 +906,14 @@ static bool s5p_jpeg_parse_hdr(struct s5p_jpeg_q_data *result, while (notfound) { c = get_byte(&jpeg_buffer); if (c == -1) - break; + return false; if (c != 0xff) continue; do c = get_byte(&jpeg_buffer); while (c == 0xff); if (c == -1) - break; + return false; if (c == 0) continue; length = 0;