From: Kim, Milo Date: Wed, 22 Aug 2012 07:32:45 +0000 (+0800) Subject: leds-lp5523: set the brightness to 0 forcely on removing the driver X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=a39b9854c79cc9ac7b7b6fed58cf07da23f1f41e;p=linux-beck.git leds-lp5523: set the brightness to 0 forcely on removing the driver Turning off the brightness of each channel is required when removing the driver. So use flush_work() rather than cancel_work_sync() to execute remaining brightness works. Signed-off-by: Milo(Woogyom) Kim Signed-off-by: Bryan Wu --- diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c index 9fd9a92ed916..2fd5689f65c0 100644 --- a/drivers/leds/leds-lp5523.c +++ b/drivers/leds/leds-lp5523.c @@ -974,7 +974,7 @@ static int __devinit lp5523_probe(struct i2c_client *client, fail2: for (i = 0; i < chip->num_leds; i++) { led_classdev_unregister(&chip->leds[i].cdev); - cancel_work_sync(&chip->leds[i].brightness_work); + flush_work(&chip->leds[i].brightness_work); } fail1: if (pdata->enable) @@ -993,7 +993,7 @@ static int lp5523_remove(struct i2c_client *client) for (i = 0; i < chip->num_leds; i++) { led_classdev_unregister(&chip->leds[i].cdev); - cancel_work_sync(&chip->leds[i].brightness_work); + flush_work(&chip->leds[i].brightness_work); } if (chip->pdata->enable)