From: Tom Yan Date: Wed, 6 Jul 2016 17:13:08 +0000 (+0800) Subject: libata-scsi: do not respond with "invalid field" for FORMAT UNIT X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=a3e8ab1b462d609147afb8df1291e54708593f15;p=linux-beck.git libata-scsi: do not respond with "invalid field" for FORMAT UNIT It does not make sense and is confusing to respond with "Invalid field in CDB" while we have no support at all implemented for FORMAT UNIT. It is decent to let it go to the default, which will respond with "Invalid command operation code" instead. Signed-off-by: Tom Yan Signed-off-by: Tejun Heo --- diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index bfec66fb26e2..f1125fd7243d 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -4039,11 +4039,6 @@ void ata_scsi_simulate(struct ata_device *dev, struct scsi_cmnd *cmd) args.done = cmd->scsi_done; switch(scsicmd[0]) { - /* TODO: worth improving? */ - case FORMAT_UNIT: - ata_scsi_invalid_field(dev, cmd, 0); - break; - case INQUIRY: if (scsicmd[1] & 2) /* is CmdDt set? */ ata_scsi_invalid_field(dev, cmd, 1);