From: Heiner Kallweit Date: Fri, 1 Jul 2016 21:08:54 +0000 (+0200) Subject: leds: triggers: return error if invalid trigger name is provided via sysfs X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=a3eac76cdf7225aa1f87aa4514664f0372b9a1c1;p=linux-beck.git leds: triggers: return error if invalid trigger name is provided via sysfs If an invalid trigger name is provided via sysfs currently no error is returned. Therefore it's not possible to determine whether the trigger was set successfully. Fix this by returning -EINVAL if no trigger is matched. Signed-off-by: Heiner Kallweit Signed-off-by: Jacek Anaszewski --- diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c index 55fa65e1ae03..c92702a684ce 100644 --- a/drivers/leds/led-triggers.c +++ b/drivers/leds/led-triggers.c @@ -60,6 +60,8 @@ ssize_t led_trigger_store(struct device *dev, struct device_attribute *attr, goto unlock; } } + /* we come here only if buf matches no trigger */ + ret = -EINVAL; up_read(&triggers_list_lock); unlock: