From: Johan Hovold <johan@hovoldconsulting.com>
Date: Wed, 13 Apr 2016 17:19:00 +0000 (+0200)
Subject: greybus: interface: disable interface on registration failures
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=a530a8be395ff2df384ca729013890f3f040cf99;p=linux-beck.git

greybus: interface: disable interface on registration failures

Disable and deactivate an interface immediately on registration
failures.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
---

diff --git a/drivers/staging/greybus/svc.c b/drivers/staging/greybus/svc.c
index b79d81717360..5a16ad33b74b 100644
--- a/drivers/staging/greybus/svc.c
+++ b/drivers/staging/greybus/svc.c
@@ -518,7 +518,12 @@ static void gb_svc_process_intf_hotplug(struct gb_operation *operation)
 		goto err_interface_deactivate;
 	}
 
-	gb_interface_add(intf);
+	ret = gb_interface_add(intf);
+	if (ret) {
+		gb_interface_disable(intf);
+		gb_interface_deactivate(intf);
+		return;
+	}
 
 	return;