From: Sachin Kamat <sachin.kamat@linaro.org>
Date: Mon, 2 Sep 2013 08:24:20 +0000 (+0530)
Subject: dma: mv_xor: Fix incorrect error path
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=a577659f42f745b71cbc56c80fb1e801ec7e6348;p=linux-beck.git

dma: mv_xor: Fix incorrect error path

Return directly if memory allocation fails. There is no need
of dma_free_coherent().

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Saeed Bishara <saeed@marvell.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---

diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
index d332b9e3f9ce..0ec086d2b6a0 100644
--- a/drivers/dma/mv_xor.c
+++ b/drivers/dma/mv_xor.c
@@ -1036,10 +1036,8 @@ mv_xor_channel_add(struct mv_xor_device *xordev,
 	struct dma_device *dma_dev;
 
 	mv_chan = devm_kzalloc(&pdev->dev, sizeof(*mv_chan), GFP_KERNEL);
-	if (!mv_chan) {
-		ret = -ENOMEM;
-		goto err_free_dma;
-	}
+	if (!mv_chan)
+		return ERR_PTR(-ENOMEM);
 
 	mv_chan->idx = idx;
 	mv_chan->irq = irq;