From: Eli Billauer Date: Sat, 16 Aug 2014 15:57:56 +0000 (+0300) Subject: staging: xillybus: Remove mmiowb() before wait_event_*() calls X-Git-Tag: v3.18-rc1~130^2~1095 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=a5b2e028bb47b4d6f4508e41120cfb2ea8aa9cac;p=karo-tx-linux.git staging: xillybus: Remove mmiowb() before wait_event_*() calls According to Documentation/memory-barriers.txt, a memory barrier is put in place by wait_event_*() Signed-off-by: Eli Billauer Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/xillybus/xillybus_core.c b/drivers/staging/xillybus/xillybus_core.c index 0214009f7513..93a3c61b1cd5 100644 --- a/drivers/staging/xillybus/xillybus_core.c +++ b/drivers/staging/xillybus/xillybus_core.c @@ -640,7 +640,6 @@ static int xilly_obtain_idt(struct xilly_endpoint *endpoint) iowrite32(1 | (3 << 24), /* Opcode 3 for channel 0 = Send IDT */ endpoint->registers + fpga_buf_ctrl_reg); - mmiowb(); /* Just to appear safe */ wait_event_interruptible_timeout(channel->wr_wait, (!channel->wr_sleepy), @@ -1986,7 +1985,6 @@ static int xilly_quiesce(struct xilly_endpoint *endpoint) wmb(); /* Make sure idtlen is set before sending command */ iowrite32((u32) (endpoint->dma_using_dac & 0x0001), endpoint->registers + fpga_dma_control_reg); - mmiowb(); wait_event_interruptible_timeout(endpoint->ep_wait, (endpoint->idtlen >= 0), @@ -2055,7 +2053,6 @@ int xillybus_endpoint_discovery(struct xilly_endpoint *endpoint) */ iowrite32((u32) (endpoint->dma_using_dac & 0x0001), endpoint->registers + fpga_dma_control_reg); - mmiowb(); wait_event_interruptible_timeout(endpoint->ep_wait, (endpoint->idtlen >= 0),