From: Chao Yu Date: Fri, 24 Jul 2015 10:26:26 +0000 (+0800) Subject: f2fs: fix to build free nids from readaheaded nat pages X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=a6d494b6d84697f954aaade204e8a5843078a94f;p=linux-beck.git f2fs: fix to build free nids from readaheaded nat pages When there is no enough free nids in free nid cache, we will try to readahead FREE_NID_PAGES:4 nat pages into page cache of meta_inode, then, reading nat entries in nat page for adding free nids to free nid cache. But when traversing all nat pages we readaheaded in a circulation, our exit condition is not set right, one more nat page will be scanned without readaheading, resulting worse read performance. This patch fixes to read the correct number nat pages to avoid bad performance. Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim --- diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 7dd2b9d78a45..ac9110788b17 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1532,7 +1532,7 @@ static void build_free_nids(struct f2fs_sb_info *sbi) if (unlikely(nid >= nm_i->max_nid)) nid = 0; - if (i++ == FREE_NID_PAGES) + if (++i >= FREE_NID_PAGES) break; }