From: Julia Lawall Date: Sun, 22 Apr 2012 11:37:09 +0000 (+0200) Subject: drivers/staging/comedi/comedi_fops.c: add missing vfree X-Git-Tag: v3.2.19~82 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=a756191d7f7f975492a9cc0f43829fcdbe366fe5;p=karo-tx-linux.git drivers/staging/comedi/comedi_fops.c: add missing vfree commit abae41e6438b798e046d721b6ccdd55b4a398170 upstream. aux_free is freed on all other exits from the function. By removing the return, we can benefit from the vfree already at the end of the function. Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman Signed-off-by: Ben Hutchings --- diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 5e78c77d5a08..4ad2c0efc5c4 100644 --- a/drivers/staging/comedi/comedi_fops.c +++ b/drivers/staging/comedi/comedi_fops.c @@ -280,7 +280,7 @@ static int do_devconfig_ioctl(struct comedi_device *dev, if (ret == 0) { if (!try_module_get(dev->driver->module)) { comedi_device_detach(dev); - return -ENOSYS; + ret = -ENOSYS; } }