From: Serge Hallyn Date: Wed, 30 Nov 2011 04:12:06 +0000 (+1100) Subject: __send_signal: pass q->info, not info, to userns_fixup_signal_uid (v2) X-Git-Tag: next-20111130~3^2~9 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=a8dfadec92437fa4939589a99b8376c90783dd22;p=karo-tx-linux.git __send_signal: pass q->info, not info, to userns_fixup_signal_uid (v2) Eric Biederman pointed out that passing info is a bug and could lead to a NULL pointer deref to boot. A collection of signal, securebits, filecaps, cap_bounds, and a few other ltp tests passed with this kernel. Changelog: Nov 18: previous patch missed a leading '&' Signed-off-by: Serge Hallyn Cc: "Eric W. Biederman" Signed-off-by: Andrew Morton --- diff --git a/kernel/signal.c b/kernel/signal.c index efe341e70952..e01633219a8b 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -1118,7 +1118,7 @@ static int __send_signal(int sig, struct siginfo *info, struct task_struct *t, break; } - userns_fixup_signal_uid(info, t); + userns_fixup_signal_uid(&q->info, t); } else if (!is_si_special(info)) { if (sig >= SIGRTMIN && info->si_code != SI_USER) {