From: Byongho Lee <bhlee.kernel@gmail.com>
Date: Wed, 27 Jan 2016 10:11:53 +0000 (+0900)
Subject: btrfs: remove redundant error check
X-Git-Tag: next-20160301~107^2~1^2~2^2~6
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=ac1407ba24d69015f88da18bfac978c493380b81;p=karo-tx-linux.git

btrfs: remove redundant error check

While running btrfs_mksubvol(), d_really_is_positive() is called twice.
First in btrfs_mksubvol() and second inside btrfs_may_create().  So I
remove the first one.

Signed-off-by: Byongho Lee <bhlee.kernel@gmail.com>
Signed-off-by: David Sterba <dsterba@suse.com>
---

diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 952172ca7e45..e65fdc8550b1 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -844,10 +844,6 @@ static noinline int btrfs_mksubvol(struct path *parent,
 	if (IS_ERR(dentry))
 		goto out_unlock;
 
-	error = -EEXIST;
-	if (d_really_is_positive(dentry))
-		goto out_dput;
-
 	error = btrfs_may_create(dir, dentry);
 	if (error)
 		goto out_dput;