From: Hannes Reinecke <hare@suse.de>
Date: Thu, 8 May 2014 06:09:56 +0000 (+0200)
Subject: scsi: set correct completion code in scsi_send_eh_cmnd()
X-Git-Tag: next-20140521~18^2~1
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=ac61d19559349e205dad7b5122b281419aa74a82;p=karo-tx-linux.git

scsi: set correct completion code in scsi_send_eh_cmnd()

->queuecommand returns '0' for successful command submission,
so we need to set the correct SCSI midlayer return value
when calling scsi_log_completion().

Signed-off-by: Hannes Reinecke <hare@suse.de>
Reported-by: Robert Elliott <elliott@hp.com>
Cc: Stephen Cameron <scameron@beardog.cce.hp.com>
Tested-by: Robert Elliott <elliott@hp.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---

diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index abe51eab3dc6..47a1ffc4c904 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -1029,6 +1029,7 @@ retry:
 		rtn = NEEDS_RETRY;
 	} else {
 		timeleft = wait_for_completion_timeout(&done, timeout);
+		rtn = SUCCESS;
 	}
 
 	shost->eh_action = NULL;