From: majianpeng Date: Thu, 14 Nov 2013 04:16:15 +0000 (+1100) Subject: raid5: Use slow_path to release stripe when mddev->thread is null X-Git-Tag: v3.13-rc1~31^2~18 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=ad4068de49862b083ac2a15bc50689bb30ce3e44;p=karo-tx-linux.git raid5: Use slow_path to release stripe when mddev->thread is null When release_stripe() is called in grow_one_stripe(), the mddev->thread is null. So it will omit one wakeup this thread to release stripe. For this condition, use slow_path to release stripe. Bug was introduced in 3.12 Cc: stable@vger.kernel.org (3.12+) Fixes: 773ca82fa1ee58dd1bf88b Signed-off-by: Jianpeng Ma Signed-off-by: NeilBrown --- diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index f8b906843926..f013d3662665 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -340,7 +340,8 @@ static void release_stripe(struct stripe_head *sh) unsigned long flags; bool wakeup; - if (test_and_set_bit(STRIPE_ON_RELEASE_LIST, &sh->state)) + if (unlikely(!conf->mddev->thread) || + test_and_set_bit(STRIPE_ON_RELEASE_LIST, &sh->state)) goto slow_path; wakeup = llist_add(&sh->release_list, &conf->released_stripes); if (wakeup)