From: Dan Carpenter Date: Thu, 12 Jul 2012 13:47:28 +0000 (-0300) Subject: [media] tvp5150: signedness bug in tvp5150_selmux() X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=afcc8e8c3474e5771ebdd49fe4f1c2ec1df997e7;p=linux-beck.git [media] tvp5150: signedness bug in tvp5150_selmux() tvp5150_read() returns negative error codes so this needs to be an int for the error handling to work. Signed-off-by: Dan Carpenter Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/video/tvp5150.c b/drivers/media/video/tvp5150.c index 0d897cb1774a..a751b6c146fd 100644 --- a/drivers/media/video/tvp5150.c +++ b/drivers/media/video/tvp5150.c @@ -257,7 +257,7 @@ static inline void tvp5150_selmux(struct v4l2_subdev *sd) int opmode = 0; struct tvp5150 *decoder = to_tvp5150(sd); int input = 0; - unsigned char val; + int val; if ((decoder->output & TVP5150_BLACK_SCREEN) || !decoder->enable) input = 8;