From: Steve French <smfrench@gmail.com>
Date: Fri, 20 Jul 2007 18:07:26 +0000 (-0500)
Subject: [GFS2] GFS2 not checking pointer on create when running under nfsd
X-Git-Tag: v2.6.24-rc1~1405^2~47
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=afd0942d98f74296b74993739e41d2ca7cb9fd5a;p=karo-tx-linux.git

[GFS2] GFS2 not checking pointer on create when running under nfsd

When looking at an unrelated problem, I noticed that nfsd does not
set nameidata pointer on create (ie nd is NULL).  This should
cause an oops in some cases in which when NFSd is mounted over GFS2.

Signed-off-by: Steve French <sfrench@us.ibm.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
---

diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c
index 911c115b5c6c..5b8b994b9912 100644
--- a/fs/gfs2/ops_inode.c
+++ b/fs/gfs2/ops_inode.c
@@ -69,7 +69,7 @@ static int gfs2_create(struct inode *dir, struct dentry *dentry,
 			mark_inode_dirty(inode);
 			break;
 		} else if (PTR_ERR(inode) != -EEXIST ||
-			   (nd->intent.open.flags & O_EXCL)) {
+			   (nd && (nd->intent.open.flags & O_EXCL))) {
 			gfs2_holder_uninit(ghs);
 			return PTR_ERR(inode);
 		}