From: Dan Carpenter <error27@gmail.com>
Date: Wed, 19 Jan 2011 14:28:27 +0000 (-0300)
Subject: [media] dib9000: fix return type in dib9000_mbx_send_attr()
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=b00aff6a36aeafc68cf9044751041ba432ab4495;p=linux-beck.git

[media] dib9000: fix return type in dib9000_mbx_send_attr()

dib9000_mbx_send_attr() returns an int.  It doesn't work to save
negative error codes in an unsigned char, so I've made "ret" an int
type.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

diff --git a/drivers/media/dvb/frontends/dib9000.c b/drivers/media/dvb/frontends/dib9000.c
index 43fb6e45424a..91518761a2da 100644
--- a/drivers/media/dvb/frontends/dib9000.c
+++ b/drivers/media/dvb/frontends/dib9000.c
@@ -486,10 +486,11 @@ static int dib9000_mbx_host_init(struct dib9000_state *state, u8 risc_id)
 #define MAX_MAILBOX_TRY 100
 static int dib9000_mbx_send_attr(struct dib9000_state *state, u8 id, u16 * data, u8 len, u16 attr)
 {
-	u8 ret = 0, *d, b[2];
+	u8 *d, b[2];
 	u16 tmp;
 	u16 size;
 	u32 i;
+	int ret = 0;
 
 	if (!state->platform.risc.fw_is_running)
 		return -EINVAL;