From: Christoph Hellwig <hch@infradead.org>
Date: Wed, 26 Sep 2012 12:00:37 +0000 (-0400)
Subject: iscsit: remove incorrect unlock in iscsit_build_sendtargets_resp
X-Git-Tag: v3.4.15~50
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=b095d61243b5f2333e2ae11a9051cd9d47597002;p=karo-tx-linux.git

iscsit: remove incorrect unlock in iscsit_build_sendtargets_resp

commit 904753da183566c71211d23c169a80184648c121 upstream.

Fix a potential multiple spin-unlock -> deadlock scenario during the
overflow check within iscsit_build_sendtargets_resp() as found by
sparse static checking.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index 20572be94148..23e122a5daf1 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -3196,7 +3196,6 @@ static int iscsit_build_sendtargets_response(struct iscsi_cmd *cmd)
 		len += 1;
 
 		if ((len + payload_len) > buffer_len) {
-			spin_unlock(&tiqn->tiqn_tpg_lock);
 			end_of_buf = 1;
 			goto eob;
 		}