From: Jan Kara Date: Thu, 22 May 2014 00:43:34 +0000 (+1000) Subject: printk: remove outdated comment X-Git-Tag: next-20140530~2^2~185 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=b1f1c11c3aa86238082c1b1836efadae2738c909;p=karo-tx-linux.git printk: remove outdated comment Comment about interesting interlocking between lockbuf_lock and console_sem is outdated. It was added in 2002 by commit a880f45a48be2956d2c78a839c472287d54435c1 during conversion of console_lock to console_sem + lockbuf_lock. At that time release_console_sem() (today's equivalent is console_unlock()) was indeed using lockbuf_lock to avoid races between trylock on console_sem in printk() and unlock of console_sem. However these days the interlocking is gone and the races are avoided by rechecking logbuf state after releasing console_sem. Signed-off-by: Jan Kara Signed-off-by: Andrew Morton --- diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 637e8ebb3a96..3ae9d512d28b 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -206,8 +206,7 @@ struct printk_log { }; /* - * The logbuf_lock protects kmsg buffer, indices, counters. It is also - * used in interesting ways to provide interlocking in console_unlock(); + * The logbuf_lock protects kmsg buffer, indices, counters. */ static DEFINE_RAW_SPINLOCK(logbuf_lock);