From: Lothar Waßmann Date: Mon, 17 Nov 2014 09:51:22 +0000 (+0100) Subject: net: fec: use swab32s() instead of cpu_to_be32() X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=b2ccb3b91d55189fd94efcca1eb732d2eebb6ef3;p=karo-tx-linux.git net: fec: use swab32s() instead of cpu_to_be32() when swap_buffer() is being called, we know for sure, that we need to byte swap the data. Furthermore, this function is called for swapping data in both directions. Thus cpu_to_be32() is semantically not correct for all use cases. Use swab32s() to reflect this. Signed-off-by: Lothar Waßmann Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index d2c7907a3403..955c2a07d842 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -297,7 +297,7 @@ static void *swap_buffer(void *bufaddr, int len) unsigned int *buf = bufaddr; for (i = 0; i < DIV_ROUND_UP(len, 4); i++, buf++) - *buf = cpu_to_be32(*buf); + swab32s(buf); return bufaddr; }