From: Johan Hovold <johan@hovoldconsulting.com>
Date: Thu, 21 Jul 2016 10:48:57 +0000 (+0200)
Subject: greybus: interface: fix interface_id attribute group
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=b5d1d1282bbb318a67fdcfc8ef2615e93d1d1724;p=linux-beck.git

greybus: interface: fix interface_id attribute group

All interfaces, regardless of type, should have an interface_id
attribute reflecting its position on the frame.

This has been reported to cause an assertion failure in libmoduleutil
for dummy modules.

Testing done: Verified that the attribute is present for registered
dummy interfaces.

Reported-by: Gjorgji Rosikopulos <grosikopulos@mm-sol.com>
Tested-by: Gjorgji Rosikopulos <grosikopulos@mm-sol.com>
Reviewed-by: Patrick Titiano <ptitiano@baylibre.com>
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
---

diff --git a/drivers/staging/greybus/interface.c b/drivers/staging/greybus/interface.c
index 919eaa0a46c7..6abe1311058f 100644
--- a/drivers/staging/greybus/interface.c
+++ b/drivers/staging/greybus/interface.c
@@ -587,7 +587,6 @@ static struct attribute *interface_unipro_attrs[] = {
 };
 
 static struct attribute *interface_greybus_attrs[] = {
-	&dev_attr_interface_id.attr,
 	&dev_attr_vendor_id.attr,
 	&dev_attr_product_id.attr,
 	&dev_attr_serial_number.attr,
@@ -603,6 +602,7 @@ static struct attribute *interface_power_attrs[] = {
 };
 
 static struct attribute *interface_common_attrs[] = {
+	&dev_attr_interface_id.attr,
 	&dev_attr_interface_type.attr,
 	NULL
 };