From: Thomas Gleixner <tglx@linutronix.de>
Date: Wed, 2 Feb 2011 22:58:19 +0000 (+0100)
Subject: genirq: Warn when handler enables interrupts
X-Git-Tag: v2.6.39-rc1~503^2~9^2~75
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=b738a50a202639614c98b5763b01bf9201779e50;p=karo-tx-linux.git

genirq: Warn when handler enables interrupts

We run all handlers with interrupts disabled and expect them not to
enable them. Warn when we catch one who does.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---

diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 3540a7190122..cdd6fbbe771c 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -68,6 +68,9 @@ irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action)
 		ret = action->handler(irq, action->dev_id);
 		trace_irq_handler_exit(irq, action, ret);
 
+		if (WARN_ON_ONCE(!irqs_disabled()))
+			local_irq_disable();
+
 		switch (ret) {
 		case IRQ_WAKE_THREAD:
 			/*
@@ -114,7 +117,6 @@ irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action)
 
 	if (status & IRQF_SAMPLE_RANDOM)
 		add_interrupt_randomness(irq);
-	local_irq_disable();
 
 	return retval;
 }