From: Dan Carpenter Date: Thu, 6 Apr 2017 05:12:20 +0000 (+0300) Subject: ath9k: off by one in ath9k_hw_nvram_read_array() X-Git-Tag: v4.12-rc1~129^2~119^2~4^2~6 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=b7dcf68f383a05567bd16a390907b67022a62d3d;p=karo-tx-linux.git ath9k: off by one in ath9k_hw_nvram_read_array() The > should be >= or we read one space beyond the end of the array. Fixes: ab5c4f71d8c7 ("ath9k: allow to load EEPROM content via firmware API") Signed-off-by: Dan Carpenter Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/ath/ath9k/eeprom.c b/drivers/net/wireless/ath/ath9k/eeprom.c index fb80ec86e53d..6ccf24814514 100644 --- a/drivers/net/wireless/ath/ath9k/eeprom.c +++ b/drivers/net/wireless/ath/ath9k/eeprom.c @@ -112,7 +112,7 @@ void ath9k_hw_usb_gen_fill_eeprom(struct ath_hw *ah, u16 *eep_data, static bool ath9k_hw_nvram_read_array(u16 *blob, size_t blob_size, off_t offset, u16 *data) { - if (offset > blob_size) + if (offset >= blob_size) return false; *data = blob[offset];