From: Josef Bacik Date: Sun, 5 Jul 2009 19:08:18 +0000 (-0700) Subject: mm: mark page accessed before we write_end() X-Git-Tag: v2.6.30.4~19 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=b8fde9988b9d0934af55dd2269dafec15f5f6302;p=karo-tx-linux.git mm: mark page accessed before we write_end() commit c8236db9cd7aa492dcfcdcca702638e704abed49 upstream. In testing a backport of the write_begin/write_end AOPs, a 10% re-read regression was noticed when running iozone. This regression was introduced because the old AOPs would always do a mark_page_accessed(page) after the commit_write, but when the new AOPs where introduced, the only place this was kept was in pagecache_write_end(). This patch does the same thing in the generic case as what is done in pagecache_write_end(), which is just to mark the page accessed before we do write_end(). Signed-off-by: Josef Bacik Acked-by: Nick Piggin Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- diff --git a/mm/filemap.c b/mm/filemap.c index 1b60f30cebfa..0b20d1f74ffc 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2249,6 +2249,7 @@ again: pagefault_enable(); flush_dcache_page(page); + mark_page_accessed(page); status = a_ops->write_end(file, mapping, pos, bytes, copied, page, fsdata); if (unlikely(status < 0))