From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Tue, 7 Mar 2017 10:25:42 +0000 (+0200)
Subject: NFC: st21nfca: Fix obvious typo when check error code
X-Git-Tag: v4.12-rc1~129^2~129^2~10
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=bacf2a6a05726e3f10aa94ef7a20feba62ee5579;p=karo-tx-linux.git

NFC: st21nfca: Fix obvious typo when check error code

We return -ENODEV if ACPI provides a GPIO resource. Looks really wrong.
If it has even been tested?

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
---

diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c
index d16f58ac09bc..c4f0d048359b 100644
--- a/drivers/nfc/st21nfca/i2c.c
+++ b/drivers/nfc/st21nfca/i2c.c
@@ -513,9 +513,9 @@ static int st21nfca_hci_i2c_acpi_request_resources(struct i2c_client *client)
 	/* Get EN GPIO from ACPI */
 	gpiod_ena = devm_gpiod_get_index(dev, ST21NFCA_GPIO_NAME_EN, 1,
 					 GPIOD_OUT_LOW);
-	if (!IS_ERR(gpiod_ena)) {
+	if (IS_ERR(gpiod_ena)) {
 		nfc_err(dev, "Unable to get ENABLE GPIO\n");
-		return -ENODEV;
+		return PTR_ERR(gpiod_ena);
 	}
 
 	phy->gpio_ena = desc_to_gpio(gpiod_ena);