From: Devendra Naga Date: Thu, 20 Sep 2012 16:10:57 +0000 (-0400) Subject: staging:ced1401: remove read write callbacks from fops X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=bae95b09076abeecd193a8efbc34c00f4309d3f6;p=linux-beck.git staging:ced1401: remove read write callbacks from fops As the driver says that read and writes should not be performed and instead the user to kernel transactions are performed through ioctl interface, remove these functions as they are not required Signed-off-by: Devendra Naga Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb1401.c index 59d69b406a21..6ba0ef652561 100644 --- a/drivers/staging/ced1401/usb1401.c +++ b/drivers/staging/ced1401/usb1401.c @@ -261,24 +261,6 @@ static int ced_flush(struct file *file, fl_owner_t id) return res; } -static ssize_t ced_read(struct file *file, char *buffer, size_t count, - loff_t * ppos) -{ - DEVICE_EXTENSION *pdx = file->private_data; - dev_err(&pdx->interface->dev, "%s called: use ioctl for cedusb", - __func__); - return 0; // as we do not do reads this way -} - -static ssize_t ced_write(struct file *file, const char *user_buffer, - size_t count, loff_t * ppos) -{ - DEVICE_EXTENSION *pdx = file->private_data; - dev_err(&pdx->interface->dev, "%s called: use ioctl for cedusb", - __func__); - return 0; -} - /*************************************************************************** ** CanAcceptIoRequests ** If the device is removed, interface is set NULL. We also clear our pointer @@ -1402,8 +1384,6 @@ static int ced_ioctl(struct inode *node, struct file *file, unsigned int cmd, static const struct file_operations ced_fops = { .owner = THIS_MODULE, - .read = ced_read, - .write = ced_write, .open = ced_open, .release = ced_release, .flush = ced_flush,