From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Wed, 28 Oct 2015 07:22:15 +0000 (+0100)
Subject: mcb: Do not return zero on error path in mcb_pci_probe()
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=bf25c19979b2ee1019201b809e93b6bca9947cfd;p=linux-beck.git

mcb: Do not return zero on error path in mcb_pci_probe()

There is an error path in mcb_pci_probe() where
it returns zero instead of error code.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/mcb/mcb-pci.c b/drivers/mcb/mcb-pci.c
index 051645498b53..67d5e7d08df6 100644
--- a/drivers/mcb/mcb-pci.c
+++ b/drivers/mcb/mcb-pci.c
@@ -51,6 +51,7 @@ static int mcb_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	priv->mapbase = pci_resource_start(pdev, 0);
 	if (!priv->mapbase) {
 		dev_err(&pdev->dev, "No PCI resource\n");
+		ret = -ENODEV;
 		goto out_disable;
 	}