From: Chase Southwood Date: Tue, 20 Jan 2015 02:42:49 +0000 (-0600) Subject: staging: comedi: das1800: prefer kmalloc_array over kmalloc with multiply X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=bff776931e6589192f07f22e1ec17b8eb878bd1a;p=linux-beck.git staging: comedi: das1800: prefer kmalloc_array over kmalloc with multiply Checkpatch doesn't like kmalloc with multiply very much: drivers/staging/comedi/drivers/das1800.c:1377: WARNING: Prefer kmalloc_array over kmalloc with multiply So this patch swaps that use out for kmalloc_array instead. Signed-off-by: Chase Southwood Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c index 381ae9440ab2..13ed31cebb7e 100644 --- a/drivers/staging/comedi/drivers/das1800.c +++ b/drivers/staging/comedi/drivers/das1800.c @@ -1374,7 +1374,7 @@ static int das1800_attach(struct comedi_device *dev, if (dev->irq & it->options[2]) das1800_init_dma(dev, it); - devpriv->fifo_buf = kmalloc(FIFO_SIZE * sizeof(uint16_t), GFP_KERNEL); + devpriv->fifo_buf = kmalloc_array(FIFO_SIZE, sizeof(uint16_t), GFP_KERNEL); if (!devpriv->fifo_buf) return -ENOMEM;