From: Tom Rini <trini@konsulko.com>
Date: Fri, 13 May 2016 14:54:04 +0000 (-0400)
Subject: kbuild: fixdep: Check fstat(2) return value
X-Git-Tag: KARO-TXSD-2017-03-15~1021
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=c1420f8b2b0f3c833c024979495ab22db34a5dbe;p=karo-tx-uboot.git

kbuild: fixdep: Check fstat(2) return value

Coverity has recently added a check that will find when we don't check
the return code from fstat(2).  Copy/paste the checking logic that
print_deps() has with an appropriate re-wording of the perror() message.

[ Linux commit : 46fe94ad18aa7ce6b3dad8c035fb538942020f2b ]

Signed-off-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Michal Marek <mmarek@suse.com>
---

diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c
index e8e8c7756d..9bd0de2490 100644
--- a/scripts/basic/fixdep.c
+++ b/scripts/basic/fixdep.c
@@ -296,7 +296,11 @@ static void do_config_file(const char *filename)
 		perror(filename);
 		exit(2);
 	}
-	fstat(fd, &st);
+	if (fstat(fd, &st) < 0) {
+		fprintf(stderr, "fixdep: error fstat'ing config file: ");
+		perror(filename);
+		exit(2);
+	}
 	if (st.st_size == 0) {
 		close(fd);
 		return;