From: H Hartley Sweeten Date: Thu, 17 Jul 2014 18:57:54 +0000 (-0700) Subject: staging: comedi: hwdrv_apci1564: remove use of comedi_error() X-Git-Tag: v3.17-rc1~123^2~550 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=c37aedfbc55dd7a71d5aa2c86b06745c021056bb;p=karo-tx-linux.git staging: comedi: hwdrv_apci1564: remove use of comedi_error() The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line characters. Use dev_err() directly instead of comedi_error() to avoid any confusion and so that all the comedi generated kernel messages have the same format. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c index 7326f3aff901..a1730e9e7135 100644 --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c @@ -102,8 +102,7 @@ static int apci1564_do_config(struct comedi_device *dev, unsigned int ul_Command = 0; if ((data[0] != 0) && (data[0] != 1)) { - comedi_error(dev, - "Not a valid Data !!! ,Data should be 1 or 0\n"); + dev_err(dev->class_dev, "Data should be 1 or 0\n"); return -EINVAL; }