From: Jes Sorensen <Jes.Sorensen@redhat.com>
Date: Tue, 5 May 2015 22:36:29 +0000 (-0400)
Subject: staging: unisys: visorchannel_clear(): No need to use vmalloc here
X-Git-Tag: v4.2-rc1~88^2~809
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=c37df5f0a0e31b1609fd931f8605f4b675d504d3;p=karo-tx-linux.git

staging: unisys: visorchannel_clear(): No need to use vmalloc here

Using a page is sufficient, and avoids the cost of vmalloc/vfree

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/unisys/visorbus/visorchannel.c b/drivers/staging/unisys/visorbus/visorchannel.c
index e555476be54d..1a1e7be6369c 100644
--- a/drivers/staging/unisys/visorbus/visorchannel.c
+++ b/drivers/staging/unisys/visorbus/visorchannel.c
@@ -214,17 +214,18 @@ visorchannel_clear(struct visorchannel *channel, ulong offset, u8 ch,
 		   ulong nbytes)
 {
 	int err;
-	int bufsize = 65536;
+	int bufsize = PAGE_SIZE;
 	int written = 0;
 	u8 *buf;
 
-	buf = vmalloc(bufsize);
+	buf = (u8 *) __get_free_page(GFP_KERNEL);
 	if (!buf)
 		return -ENOMEM;
 
 	memset(buf, ch, bufsize);
+
 	while (nbytes > 0) {
-		ulong thisbytes = bufsize;
+		int thisbytes = bufsize;
 
 		if (nbytes < thisbytes)
 			thisbytes = nbytes;
@@ -239,7 +240,7 @@ visorchannel_clear(struct visorchannel *channel, ulong offset, u8 ch,
 	err = 0;
 
 cleanup:
-	vfree(buf);
+	free_page((unsigned long) buf);
 	return err;
 }
 EXPORT_SYMBOL_GPL(visorchannel_clear);