From: Thomas Meyer Date: Tue, 29 Nov 2011 21:08:00 +0000 (+0100) Subject: fuse: Use kcalloc instead of kzalloc to allocate array X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=c411cc88d873b3f68635a04691f7f115c46bc39e;p=linux-beck.git fuse: Use kcalloc instead of kzalloc to allocate array The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas Meyer Signed-off-by: Miklos Szeredi --- diff --git a/fs/fuse/file.c b/fs/fuse/file.c index e0b60acfe726..c297425cba71 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -1776,7 +1776,7 @@ long fuse_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg, BUILD_BUG_ON(sizeof(struct fuse_ioctl_iovec) * FUSE_IOCTL_MAX_IOV > PAGE_SIZE); err = -ENOMEM; - pages = kzalloc(sizeof(pages[0]) * FUSE_MAX_PAGES_PER_REQ, GFP_KERNEL); + pages = kcalloc(FUSE_MAX_PAGES_PER_REQ, sizeof(pages[0]), GFP_KERNEL); iov_page = (struct iovec *) __get_free_page(GFP_KERNEL); if (!pages || !iov_page) goto out;