From: Ashvini Varatharaj Date: Sat, 19 Oct 2013 03:30:59 +0000 (+0530) Subject: Staging: speakup: removing jiffies comparison in speakup_apollo.c X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=c45a9a9bf3b179ec1543d4e4e5fe0a7b6e82548e;p=linux-beck.git Staging: speakup: removing jiffies comparison in speakup_apollo.c Fix checkpatch warning: WARNING: Comparing jiffies is almost always wrong; prefer time_after, time_before and friends Signed-off-by: Ashvini Varatharaj Reviewed-by: Peter P Waskiewicz Jr Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/speakup/speakup_apollo.c b/drivers/staging/speakup/speakup_apollo.c index 95d3132f0a35..70cf1591676a 100644 --- a/drivers/staging/speakup/speakup_apollo.c +++ b/drivers/staging/speakup/speakup_apollo.c @@ -179,7 +179,7 @@ static void do_catch_up(struct spk_synth *synth) schedule_timeout(msecs_to_jiffies(full_time_val)); continue; } - if ((jiffies >= jiff_max) && (ch == SPACE)) { + if (time_after_eq(jiffies, jiff_max) && (ch == SPACE)) { spin_lock_irqsave(&speakup_info.spinlock, flags); jiffy_delta_val = jiffy_delta->u.n.value; full_time_val = full_time->u.n.value;