From: Dan Carpenter Date: Fri, 18 Nov 2016 11:30:24 +0000 (-0200) Subject: [media] staging: media: davinci_vpfe: unlock on error in vpfe_reqbufs() X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=c4a407b91f4b644145492e28723f9f880efb1da0;p=linux-beck.git [media] staging: media: davinci_vpfe: unlock on error in vpfe_reqbufs() We should unlock before returning this error code in vpfe_reqbufs(). Fixes: 622897da67b3 ("[media] davinci: vpfe: add v4l2 video driver support") Signed-off-by: Dan Carpenter Signed-off-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/vpfe_video.c index 8fd3f7cd40d6..c27d7e9a1bdb 100644 --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c @@ -1362,7 +1362,7 @@ static int vpfe_reqbufs(struct file *file, void *priv, ret = vb2_queue_init(q); if (ret) { v4l2_err(&vpfe_dev->v4l2_dev, "vb2_queue_init() failed\n"); - return ret; + goto unlock_out; } fh->io_allowed = 1;