From: Axel Lin Date: Mon, 16 Feb 2015 14:39:04 +0000 (+0800) Subject: serial: sprd: Fix missing spin_unlock in sprd_handle_irq() X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=c4e6dcfa00dab9b10e75bba835393b81f256310b;p=linux-beck.git serial: sprd: Fix missing spin_unlock in sprd_handle_irq() Fix return from sprd_handle_irq() with spin_lock held. Signed-off-by: Axel Lin Reviewed-by: Peter Hurley Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c index 594b63331ef4..bca975f5093b 100644 --- a/drivers/tty/serial/sprd_serial.c +++ b/drivers/tty/serial/sprd_serial.c @@ -293,8 +293,10 @@ static irqreturn_t sprd_handle_irq(int irq, void *dev_id) ims = serial_in(port, SPRD_IMSR); - if (!ims) + if (!ims) { + spin_unlock(&port->lock); return IRQ_NONE; + } serial_out(port, SPRD_ICLR, ~0);