From: Max Kellermann Date: Mon, 21 Mar 2016 13:30:33 +0000 (-0300) Subject: [media] drivers/media/media-device: move debug log before _devnode_unregister() X-Git-Tag: v4.7-rc1~130^2~18 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=c56d34a73ea3622fbc3f5a85140f2353f14b591c;p=karo-tx-linux.git [media] drivers/media/media-device: move debug log before _devnode_unregister() After media_devnode_unregister(), the struct media_device may be freed already, and dereferencing it may crash. Signed-off-by: Max Kellermann Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index 898a3cf814ba..de92a6bf3751 100644 --- a/drivers/media/media-device.c +++ b/drivers/media/media-device.c @@ -801,9 +801,8 @@ void media_device_unregister(struct media_device *mdev) mutex_unlock(&mdev->graph_mutex); device_remove_file(&mdev->devnode.dev, &dev_attr_model); + dev_dbg(mdev->dev, "Media device unregistering\n"); media_devnode_unregister(&mdev->devnode); - - dev_dbg(mdev->dev, "Media device unregistered\n"); } EXPORT_SYMBOL_GPL(media_device_unregister);