From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 17 Feb 2012 06:45:01 +0000 (+0300)
Subject: viafb: NULL dereference on allocation failure in query_edid()
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=c572c8bbff13591f6c9f249d4413f79ddda21e61;p=linux-beck.git

viafb: NULL dereference on allocation failure in query_edid()

We should handle the allocation here, if only to keep the static
checkers happy.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
---

diff --git a/drivers/video/via/via_aux_edid.c b/drivers/video/via/via_aux_edid.c
index 03f7a41c8a3f..754d4509033f 100644
--- a/drivers/video/via/via_aux_edid.c
+++ b/drivers/video/via/via_aux_edid.c
@@ -36,10 +36,13 @@ static void query_edid(struct via_aux_drv *drv)
 	unsigned char edid[EDID_LENGTH];
 	bool valid = false;
 
-	if (spec)
+	if (spec) {
 		fb_destroy_modedb(spec->modedb);
-	else
+	} else {
 		spec = kmalloc(sizeof(*spec), GFP_KERNEL);
+		if (!spec)
+			return;
+	}
 
 	spec->version = spec->revision = 0;
 	if (via_aux_read(drv, 0x00, edid, EDID_LENGTH)) {