From: Dan Carpenter Date: Mon, 3 May 2010 03:08:15 +0000 (+0800) Subject: crypto: algapi - Remove unneeded null check X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=c614e109c184edd7900d9ff4d6de9ef94bc4d85b;p=linux-beck.git crypto: algapi - Remove unneeded null check We don't check "frontend" consistently in crypto_init_spawn2(). We check it at the start of the function but then we dereference it unconditionally in the parameter list when we call crypto_init_spawn(). I looked at the places that call crypto_init_spawn2() and "frontend" is always a valid pointer so I removed the check for null. Signed-off-by: Dan Carpenter Signed-off-by: Herbert Xu --- diff --git a/crypto/algapi.c b/crypto/algapi.c index 3e4524e6139b..d49d7091cecf 100644 --- a/crypto/algapi.c +++ b/crypto/algapi.c @@ -543,7 +543,7 @@ int crypto_init_spawn2(struct crypto_spawn *spawn, struct crypto_alg *alg, { int err = -EINVAL; - if (frontend && (alg->cra_flags ^ frontend->type) & frontend->maskset) + if ((alg->cra_flags ^ frontend->type) & frontend->maskset) goto out; spawn->frontend = frontend;