From: Franck Jullien Date: Tue, 22 Mar 2016 10:43:58 +0000 (-0300) Subject: [media] xilinx-vipp: remove unnecessary of_node_put X-Git-Tag: v4.7-rc1~130^2~16 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=c64ee34712eeeee95de0376f424dd4dc7661d3ed;p=karo-tx-linux.git [media] xilinx-vipp: remove unnecessary of_node_put of_graph_get_next_endpoint(node, ep) decrements refcount on ep. When next==NULL we break and refcount on ep is decremented again. Signed-off-by: Franck Jullien Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c index e795a4501e8b..feb3b2f1d874 100644 --- a/drivers/media/platform/xilinx/xilinx-vipp.c +++ b/drivers/media/platform/xilinx/xilinx-vipp.c @@ -351,19 +351,15 @@ static int xvip_graph_parse_one(struct xvip_composite_device *xdev, struct xvip_graph_entity *entity; struct device_node *remote; struct device_node *ep = NULL; - struct device_node *next; int ret = 0; dev_dbg(xdev->dev, "parsing node %s\n", node->full_name); while (1) { - next = of_graph_get_next_endpoint(node, ep); - if (next == NULL) + ep = of_graph_get_next_endpoint(node, ep); + if (ep == NULL) break; - of_node_put(ep); - ep = next; - dev_dbg(xdev->dev, "handling endpoint %s\n", ep->full_name); remote = of_graph_get_remote_port_parent(ep);