From: Andrew Morton <akpm@linux-foundation.org>
Date: Tue, 26 Mar 2013 23:25:04 +0000 (+1100)
Subject: argv_split-teach-it-to-handle-mutable-strings-fix
X-Git-Tag: next-20130404~3^2~299
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=c6c7db5816d9061a769c46dda626f4da6220c682;p=karo-tx-linux.git

argv_split-teach-it-to-handle-mutable-strings-fix

Cc: Andi Kleen <andi@firstfloor.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

diff --git a/lib/argv_split.c b/lib/argv_split.c
index fa7d30abd5d4..cac7ec49e149 100644
--- a/lib/argv_split.c
+++ b/lib/argv_split.c
@@ -51,6 +51,10 @@ EXPORT_SYMBOL(argv_free);
  * considered to be a single argument separator.  The returned array
  * is always NULL-terminated.  Returns NULL on memory allocation
  * failure.
+ *
+ * The source string at `str' may be undergoing concurrent alteration via
+ * userspace sysctl activity (at least).  The argv_split() implementation
+ * attempts to handle this gracefully by taking a local copy to work on.
  */
 char **argv_split(gfp_t gfp, const char *str, int *argcp)
 {