From: Nicholas Mc Guire Date: Sat, 11 Apr 2015 13:10:37 +0000 (+0200) Subject: drm/msm: wait_for_completion_timeout return is never negative X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=c6d0baf1fdbe32594e6e8bf6870f3951d3cf6415;p=linux-beck.git drm/msm: wait_for_completion_timeout return is never negative wait_for_completion_timeout returns >= 0 but never negative - so the error check should be against equality to 0 not <= 0. Signed-off-by: Nicholas Mc Guire Signed-off-by: Rob Clark --- diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c b/drivers/gpu/drm/msm/edp/edp_ctrl.c index 17ae0cc3db70..43e549ba7258 100644 --- a/drivers/gpu/drm/msm/edp/edp_ctrl.c +++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c @@ -1032,7 +1032,7 @@ static void edp_ctrl_off_worker(struct work_struct *work) time_left = wait_for_completion_timeout(&ctrl->idle_comp, msecs_to_jiffies(500)); - if (time_left <= 0) + if (!time_left) DBG("%s: idle pattern timedout, %lu\n", __func__, time_left);