From: Malcolm Priestley <tvboxspy@gmail.com>
Date: Thu, 4 Sep 2014 22:08:36 +0000 (+0100)
Subject: staging: vt6655: device_free_info() warn: variable dereferenced before check
X-Git-Tag: v3.18-rc1~130^2~628
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=c72f65cccab03dc9524a3d7fa385f31d5b6ae377;p=karo-tx-linux.git

staging: vt6655: device_free_info() warn: variable dereferenced before check

pDevice is never NULL when this function is called remove the check.

This fixes smatch warning
drivers/staging/vt6655/device_main.c:1023 device_free_info() warn: variable dereferenced
before check 'pDevice' (see line 1021)

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kbuild@01.org
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index f33795faa09b..7e7d9affbc12 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -1008,9 +1008,6 @@ static void device_free_info(struct vnt_private *pDevice)
 {
 	struct net_device *dev = pDevice->dev;
 
-	if (!pDevice)
-		return;
-
 	ASSERT(pDevice);
 //2008-0714-01<Add>by chester
 	device_release_WPADEV(pDevice);