From: Dan Carpenter Date: Thu, 24 Jan 2013 08:51:22 +0000 (+0000) Subject: PM: intel_powerclamp: off by one in start_power_clamp() X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=c8165dc0ea75855b0bff6e5edbe4957b8a63d021;p=linux-beck.git PM: intel_powerclamp: off by one in start_power_clamp() This value has already been clamped correctly to 0 through 49 in powerclamp_set_cur_state() so this patch doesn't actually change anything. But we should fix it anyway for consistency. set_target_ratio is used as an offset into an array with MAX_TARGET_RATIO (50) elements. Signed-off-by: Dan Carpenter Signed-off-by: Zhang Rui --- diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c index a85ff38cb4e8..ab3ed907d2c3 100644 --- a/drivers/thermal/intel_powerclamp.c +++ b/drivers/thermal/intel_powerclamp.c @@ -504,7 +504,7 @@ static int start_power_clamp(void) return -EINVAL; } - set_target_ratio = clamp(set_target_ratio, 0U, MAX_TARGET_RATIO); + set_target_ratio = clamp(set_target_ratio, 0U, MAX_TARGET_RATIO - 1); /* prevent cpu hotplug */ get_online_cpus();