From: Saurav Kashyap Date: Tue, 16 Aug 2011 18:31:46 +0000 (-0700) Subject: [SCSI] qla2xxx: Prevent CPU lockups when "ql2xdontresethba" module param is set. X-Git-Tag: next-20110830~54^2~20 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=c8582ad95bcbdf46f799d310d7dfee73d941c2f4;p=karo-tx-linux.git [SCSI] qla2xxx: Prevent CPU lockups when "ql2xdontresethba" module param is set. Driver is not releasing the lock if ql2xdontresethba is set, this might lead to a lockup. Signed-off-by: Saurav Kashyap Signed-off-by: Chad Dupuis Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c index b03c86b7a989..fe9db224794d 100644 --- a/drivers/scsi/qla2xxx/qla_nx.c +++ b/drivers/scsi/qla2xxx/qla_nx.c @@ -3761,10 +3761,15 @@ qla82xx_device_state_handler(scsi_qla_host_t *vha) qla82xx_idc_lock(ha); break; case QLA82XX_DEV_NEED_RESET: - if (!ql2xdontresethba) - qla82xx_need_reset_handler(vha); + if (!ql2xdontresethba) + qla82xx_need_reset_handler(vha); + else { + qla82xx_idc_unlock(ha); + msleep(1000); + qla82xx_idc_lock(ha); + } dev_init_timeout = jiffies + - (ha->nx_dev_init_timeout * HZ); + (ha->nx_dev_init_timeout * HZ); break; case QLA82XX_DEV_NEED_QUIESCENT: qla82xx_need_qsnt_handler(vha);